Rerun when github changes view (Removes our tree) #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voliva
commented
Mar 27, 2018
|
|
||
| function initialSetup() { | ||
| if ($('.js-diff-progressive-spinner').length || !$('#files').length) { | ||
| setTimeout(initialSetup, 100); |
Contributor
Author
There was a problem hiding this comment.
This is not needed anymore, as the setInterval of start() will recall this when the tree is missing.
picheli20
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, github takes a while to update his view when a URL changes. This makes it that this extension "thinks" it already injected the HTML when github refreshes the page and removes it.
In here, I check for the injected HTML tree to actually be in the DOM, so it gets reinjected when github refreshes its view.